Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for #24889 #42731

Merged
merged 1 commit into from
Jun 18, 2017
Merged

Add test for #24889 #42731

merged 1 commit into from
Jun 18, 2017

Conversation

MaloJaffre
Copy link
Contributor

Fixes #24889.
r? @Mark-Simulacrum (Thanks for the instructions).

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@Mark-Simulacrum
Copy link
Member

Thanks! Let me know (here or on IRC is fine) if you'd like to write tests for more of the E-needstest issues, I'd be happy to provide instructions.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 18, 2017

📌 Commit a5403d0 has been approved by Mark-Simulacrum

@MaloJaffre
Copy link
Contributor Author

@Mark-Simulacrum I will try to do few more tests, and ask your help if I have problems.

@Mark-Simulacrum
Copy link
Member

Note that quite a few have been added in #42724.

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 18, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#42731 - MaloJaffre:issue-24889, r=Mark-Simu…
db9c12c 
…lacrum

Add test for rust-lang#24889

Fixes rust-lang#24889.
r? @Mark-Simulacrum (Thanks for the instructions).
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jun 18, 2017
Merged
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Jun 18, 2017
@frewsxcv
Rollup merge of rust-lang#42731 - MaloJaffre:issue-24889, r=Mark-Simu…
6a3250a 
…lacrum

Add test for rust-lang#24889

Fixes rust-lang#24889.
r? @Mark-Simulacrum (Thanks for the instructions).
@frewsxcv frewsxcv mentioned this pull request Jun 18, 2017
Closed
bors added a commit that referenced this pull request Jun 18, 2017
@bors
Auto merge of #42738 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
247a018 
Rollup of 7 pull requests

- Successful merges: #42695, #42714, #42720, #42723, #42730, #42731, #42734
- Failed merges: #42722
@bors bors merged commit a5403d0 into rust-lang:master Jun 18, 2017
@MaloJaffre MaloJaffre deleted the issue-24889 branch June 18, 2017 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MaloJaffre @rust-highfive @Mark-Simulacrum @bors